go-gitea / gitea

Git with a cup of tea! Painless self-hosted all-in-one software development service, including Git hosting, code review, team collaboration, package registry and CI/CD
https://gitea.com
MIT License
45.25k stars 5.5k forks source link

Fix incorrect project page CSS class #32510

Closed wxiaoguang closed 1 week ago

wxiaoguang commented 1 week ago

Otherwise milestone JS would run on this page and cause errors

wxiaoguang commented 1 week ago

I hope this was sufficiently tested.

Hopefully so. Otherwise, the JS error happens in initRepoMilestone.

Before there was no problem because old code used jQuery, it ignored non-existing elements.

But new code uses JS DOM, then the wrong CSS class causes wrong code execution.

Indeed, the CSS class is wrong, it shouldn't be there.