search

go-gitea / gitea

Git with a cup of tea! Painless self-hosted all-in-one software development service, including Git hosting, code review, team collaboration, package registry and CI/CD
https://gitea.com
MIT License
44.19k stars 5.42k forks source link

Markdown checkboxes in tables #5875

Open ghost opened 5 years ago

ghost commented 5 years ago

Description

Checkboxes inside markdown tables are not rendered as checkboxes. See https://try.gitea.io/transferkraM/markdown-checkbox-table.

zamiere commented 5 years ago

Another issue is the dots before the checkboxes. Put an inline "list-style-type: none" on these elements.

stale[bot] commented 5 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

ghost commented 5 years ago

Push.

grayminds commented 5 years ago

^bump

lunny commented 4 years ago

I think this has been fixed since we use goldmark. Also see the original link https://try.gitea.io/transferkraM/markdown-checkbox-table

guillep2k commented 4 years ago

I think this has been fixed since we use goldmark. Also see the original link https://try.gitea.io/transferkraM/markdown-checkbox-table

@lunny I don't see this fixed. I expect to see checkboxes inside the table.

maria-lau commented 4 years ago

A couple things I've noticed:

  1. I can't interact with checkboxes in a PR. (e.g. I can't click on it to mark it done)
  2. Checkboxes are rendered with a bullet (it normally isn't rendered with one, see example below)
    • [ ] task 1
    • [ ] task 2
michaesc commented 4 years ago

This bug is present in Gitea 1.11.4, and it's rather annoying. I confirm that the flaws @maria-lau stated regarding interaction and nonstandard (redundant) bullet symbols are present in the most recent release, according to changelogs since 1.11.4.

Note

It's possible that the release candidate tagged v1.12.0-rc1 solves the problem, with respect to #10798 (Completely fix task-list checkbox styling.) Nevertheless the release candidate is not a release, and it's unclear if the bug #10798 solves this problem as well.

zeripath commented 4 years ago

I cannot find the spec that describes how checkboxes are supposed to work in tables. GFM doesn't appear to have these:

inside table

checkboxes description
[ ] unchecked
[x] checked

I have fixed the appearance of normal checkboxes in #10798 - I haven't backported them as we're in the midst of prepping for 1.12 - feel free however to make your own PR.

In terms of making these clickable and submittable - this is not supported as yet. Again PRs are welcome but it's not a simple thing to make work.

wxiaoguang commented 2 years ago

GitHub

Task Time required Assigned to Current Status Finished
Calendar Cache > 5 hours in progress - [x] ok?
Object Cache > 5 hours in progress [x] item1
[ ] item2
Object Cache > 5 hours in progress
  • - [x] item1
  • - [ ] item2
Object Cache > 5 hours in progress
  • [x] item1
  • [ ] item2

Gitea

image

davama commented 8 months ago

This would be a great feature! Thanks!