go-gitea / gitea

Git with a cup of tea! Painless self-hosted all-in-one software development service, including Git hosting, code review, team collaboration, package registry and CI/CD
https://gitea.com
MIT License
44.52k stars 5.44k forks source link

webhook compare_url is not filled in #6441

Open luvarqpp opened 5 years ago

luvarqpp commented 5 years ago

Description

Short: In POST request there is field "compare_url", which is not filled in. parsing "compare_url"

Long desc

I have installed gitea server together with jenkins instance and I have installed gitea plugin for jenkins. Than I have set-up single jenkins job (gitea organization). It have found some repositories and created multibranch job for them. Also webhooks in gitea was set-up by jenkins plugin automatically (as it was requested in jenkins plugin settings).

Disclaimer: I have not studied gitea jenkins plugin deeply, I have just done some basic "grep" for some keywords.

It seems that webhooks are working and I see that delivery was successful (http 200 response with body: "Processed"). There is no trigerred jenkins builds through. I have find out that jenkins plugin is parsing "compare_url" from data. Given attribute is set to be empty string, so I think that this is root of my problem.

Another source code is suggesting that match is done using html url.

stale[bot] commented 5 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.