search

go-gitea / gitea

Git with a cup of tea! Painless self-hosted all-in-one software development service, including Git hosting, code review, team collaboration, package registry and CI/CD
https://gitea.com
MIT License
45.06k stars 5.49k forks source link

Docker guidelines text #696

Closed jmn closed 7 years ago

jmn commented 7 years ago

Hi, Using latest Docker image:

There is a link in "Install Steps For First-time Run": "If you're running Gitea inside Docker, please read Guidelines carefully before you change anything in this page!" The link is to https://github.com/go-gitea/gitea/tree/master/docker contains configuration files.

Perhaps create a README.MD in the directory containing these outlines?

tullo commented 7 years ago

The readme exists in v0.9 https://github.com/go-gitea/gitea/tree/release/v0.9/docker but did not make it to current version for reasons unknown to me.

tboerger commented 7 years ago

Where do you get this information? The docker guide should be part of the docs

tullo commented 7 years ago

Maybe add a link to the docs in a minimal readme. I recently moved my stuff from gogs to gitea and could not remember how i started the gogs docker instance and googled "install gogs docker" where the the first hit gets you to https://github.com/gogits/gogs/tree/master/docker and i guess that the OP made the same assumptions as me and expected to find the info at the same location in the githea repo

tboerger commented 7 years ago

Than we should add readme files to every directory. IMHO a docs page is always the first source you should look at, and there you can also directly see it.

jmn commented 7 years ago

If Docker guidelines has been written, why not link to them in https://github.com/go-gitea/gitea/blob/74ed6dc3ad830d308a032fe213e9dfe83f954ffc/options/locale/locale_en-US.ini#L55

jmn commented 7 years ago

By the way, This is how https://docs.gitea.io/en-us/install-with-docker/ looks at the moment for me: (tested with Chromium, Chrome Canary on Windows 10) chrome_2017-01-25_00-27-13

tboerger commented 7 years ago

That's exactly the part I asked for.

lunny commented 7 years ago

It's a UI bug. @jmn could you fire an issue on go-gitea/docs ?

jmn commented 7 years ago

OK see go-gitea/docs/issues/85

lunny commented 7 years ago

Thanks.

tboerger commented 7 years ago

@lunny why should he report a theme issue to the docs?

lunny commented 7 years ago

@tboerger you mean that's hugo's bug?

tboerger commented 7 years ago

@lunny no, a theme bug. I'm pretty sure this is related to an unproperly pinned bootstrap version. As MetalMatze used the bootstrap 4 beta and they switched the grid system

jmn commented 7 years ago

It's hard to know which repo to report to for the website. The website shares the theme with Gitea the app?

tboerger commented 7 years ago

The repo "theme" is the shared Hugo theme for the website, docs, blog and code redirects.

lunny commented 7 years ago

So this issue should be moved to go-gitea/theme?

jmn commented 7 years ago

Pardon me for going off topic in the first place, the CSS issue is now at https://github.com/go-gitea/theme/issues/31

This issue is about the reference to documentation in "Install Steps For First-time Run": which is in this code https://github.com/go-gitea/gitea/blob/74ed6dc3ad830d308a032fe213e9dfe83f954ffc/options/locale/locale_en-US.ini#L55

lunny commented 7 years ago

I think go-gitea/theme#31 have resolved this. So let's close it. Please feel free to reopen it.

tboerger commented 7 years ago

We have to fix the link within Gitea itself.