search

go-gitea / gitea

Git with a cup of tea! Painless self-hosted all-in-one software development service, including Git hosting, code review, team collaboration, package registry and CI/CD
https://gitea.com
MIT License
45.08k stars 5.49k forks source link

When requesting captcha, it will request database. #7408

Closed lunny closed 5 years ago

lunny commented 5 years ago 
2019/07/10 09:51:03 Started GET /captcha/fBPQG36n8I4J2Yr.png?reload=1562723463256 for [::1]
2019/07/10 09:51:03 .../xorm/session_get.go:99:nocacheGet() [I] [SQL] SELECT `id`, `lower_name`, `name`, `full_name`, `email`, `keep_email_private`, `passwd`, `passwd_hash_algo`, `must_change_password`, `login_type`, `login_source`, `login_name`, `type`, `location`, `website`, `rands`, `salt`, `language`, `description`, `created_unix`, `updated_unix`, `last_login_unix`, `last_repo_visibility`, `max_repo_creation`, `is_active`, `is_admin`, `allow_git_hook`, `allow_import_local`, `allow_create_organization`, `prohibit_login`, `avatar`, `avatar_email`, `use_custom_avatar`, `num_followers`, `num_following`, `num_stars`, `num_repos`, `num_teams`, `num_members`, `visibility`, `diff_view_style`, `theme` FROM `user` WHERE `lower_name`=? LIMIT 1 []interface {}{"captcha"}
2019/07/10 09:51:03 Completed GET /captcha/fBPQG36n8I4J2Yr.png?reload=1562723463256 200 OK in 119.484905ms

When a middleware has written something to ResponseWriter, it should not go to match the URL? Is this a bug of macaron or our wrong configuration?

zeripath commented 5 years ago

Was this fixed by #7407?

lunny commented 5 years ago

I think no.

stale[bot] commented 5 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

lunny commented 5 years ago

I will check if this is still in v1.10.

lunny commented 5 years ago

This has gone on 1.10.0+dev-277-g5e67e0100