Umlauts not allowed in repo topic/misleading error message

[dadosch]

• Gitea version (or commit ref): 1.8.3
• Git version: not relevant
• Operating system: Arch Linux
• Database (use [x]):
  • [ ] PostgreSQL
  • [x] MySQL
  • [ ] MSSQL
  • [ ] SQLite
• Can you reproduce the bug at https://try.gitea.io:
  • [ ] Yes (provide example URL)
  • [ ] No
  • [x] Not relevant
• Log gist:

Description

When you try to add a topic to a repo with a Umlaut in it (äüö etc.) Gitea doesn't save it, but rather displays an error message that topics have to start with a letter or a number and must be no longer than 35 characters.

Screenshots

[mrsdizzie]

This is bug of the original EN description since we only allow ASCII A-Za-z which is different than all "letters". I think we could do better for topics though and allow more characters like this example.

I think we could expand the check from ^[a-z0-9][a-z0-9-]*$ to ^[\p{L}0-9][\p{L}0-9-]*$ which is supported in Go.

See https://regex101.com/r/CoHxiW/2

[mrsdizzie]

We also check this in the front end in Javascript which unfortunately doesn't support unicode property escapes until ECMAScript 2018, turning this from a one line fix into something else :( I think we should get rid of that and validate in go and use ctx.Flash.Error like we do other places.

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 weeks. Thank you for your contributions.

[OtherSystems]

Hi, I run into something similar when trying to import non-english projects (in this care hawaiian). Some of the characters are not allowed.