search

go-gitea / gitea

Git with a cup of tea! Painless self-hosted all-in-one software development service, including Git hosting, code review, team collaboration, package registry and CI/CD
https://gitea.com
MIT License
44.6k stars 5.45k forks source link

Update go-macaron/cache and go-macaron/session #7670

Closed tamalsaha closed 5 years ago

tamalsaha commented 5 years ago

I would like to update the go-macaron/cache and go-macaron/session packages to use the latest version of go-redis client. The latest client has support for Redis cluster. I opened prs against the macaron repos for 2 months which have not been merged.

How can gitea use my updated version of the macaron libraries?

techknowlogick commented 5 years ago

There has been some discussion on switching away from macaron due to several issues, one of which you mentioned (pending PRs not being merged for >2mos). The issue is #7403.

I think while we work on the above, we may need to fork macaron in the interim so we can add fixes, such as the ones above. Maybe we create a new org on gitea.com (we'd need to rename macaron to something else) with the macaron repos in it that Gitea project can maintain itself.

@lunny @zeripath thoughts?

lunny commented 5 years ago

I suggest we convert to gin web framework and we can maintain some gin's middlewares. I think we can do something on v1.10 and v1.11

techknowlogick commented 5 years ago

I like gin, but that will take time to convert. I think short-term fork of macaron would be good while we wait for #7403

lunny commented 5 years ago

For a short-term target, I like your idea to create a new org in gitea.com to fork macaron's repositories.

tamalsaha commented 5 years ago

I also agree with maintaining forked repos for now.

lunny commented 5 years ago

I have created fork organization https://gitea.com/macaron and I think we can move some gitea internal middlewares to that organization

tamalsaha commented 5 years ago

@techknowlogick / @lunny / @zeripath , it seems that the following macaron repos should be forked too, since the main macaron repo has been forked.

lunny commented 5 years ago

All above forked, but need PRs.

tamalsaha commented 5 years ago

@lunny , can you please add drone for the repos? I can send pr for the go.mod stuff.

lunny commented 5 years ago

@tamalsaha all drone added.