search

go-gitea / gitea

Git with a cup of tea! Painless self-hosted all-in-one software development service, including Git hosting, code review, team collaboration, package registry and CI/CD
https://gitea.com
MIT License
44.59k stars 5.45k forks source link

[Bug] Go-Dependency | invalid pseudo-versio #8387

Closed 6543 closed 5 years ago

6543 commented 5 years ago

go: github.com/go-macaron/cors@v0.0.0-20190309005821-6fd6a9bfe14e9: invalid pseudo-version: revision is longer than canonical (6fd6a9bfe14e)

6543 commented 5 years ago

needed for https://github.com/alpinelinux/aports/pull/10887

techknowlogick commented 5 years ago

This is resolved in gitea 1.10-dev, We are unable to backport it.

Gitea 1.9.x does not support go1.13

6543 commented 5 years ago

@techknowlogick alpinelinux user are still on giea version 1.8.3 ! an i had a PR wich get tehm 1.9.3 but this is blocking it and to wait until 1.10.x has its first stable release will take a wile :(

techknowlogick commented 5 years ago

@6543 sadly this error is caused by an upstream library, and we have resolved this, but sadly in a way that can't be backported. 1.10 milestone is almost complete (less than 5 PRs left).

6543 commented 5 years ago

this: https://tip.golang.org/doc/go1.13#version-validation is telling me that we would only add one line in go.mod

6543 commented 5 years ago

the diff would be:

diff --git a/go.mod b/go.mod
index 2c137af81..629d35ea7 100644
--- a/go.mod
+++ b/go.mod
@@ -46,7 +46,7 @@ require (
        github.com/go-macaron/binding v0.0.0-20160711225916-9440f336b443
        github.com/go-macaron/cache v0.0.0-20151013081102-561735312776
        github.com/go-macaron/captcha v0.0.0-20190710000913-8dc5911259df
-       github.com/go-macaron/cors v0.0.0-20190309005821-6fd6a9bfe14e9
+       github.com/go-macaron/cors 6fd6a9bfe14e9
        github.com/go-macaron/csrf v0.0.0-20180426211211-503617c6b372
        github.com/go-macaron/i18n v0.0.0-20160612092837-ef57533c3b0f
        github.com/go-macaron/inject v0.0.0-20160627170012-d8a0b8677191
techknowlogick commented 5 years ago

Please send PR for this against release/v1.9 banch :)

6543 commented 5 years ago

THANKS

I'll make some tests before

6543 commented 5 years ago

with the first changes make will get an errror but go build run just fine ... after it the diff looks similar but now make run too ...

ill send the final patch as PR ...

6543 commented 5 years ago

@techknowlogick https://github.com/go-gitea/gitea/pull/8389