search

go-gitea / gitea

Git with a cup of tea! Painless self-hosted all-in-one software development service, including Git hosting, code review, team collaboration, package registry and CI/CD
https://gitea.com
MIT License
44.68k stars 5.46k forks source link

Get issue comments API didn't return review details #9345

Open NepPure opened 4 years ago

NepPure commented 4 years ago

Description

Test PR https://try.gitea.io/oyyzowen/test2/pulls/5?lang=en-US

API:/repos/{owner}/{repo}/issues/{index}/comments don't work as expected.

Screenshots

image

image

NepPure commented 4 years ago

https://github.com/go-gitea/gitea/blob/59fc29db383142586b6ac5cab7b324f16553e561/routers/api/v1/repo/issue_comment.go#L64

Include CommentTypeCode, add a new API, or add a parameter for comment type filtering?
Which solution would be better?

lunny commented 4 years ago

Maybe github could give use some idea.

NepPure commented 4 years ago

https://developer.github.com/v3/pulls/comments/#list-comments-on-a-pull-request

Github has a separate set of APIs for pull request.
We can get review details from https://api.github.com/repos/go-gitea/gitea/pulls/9274/comments

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. I am here to help clear issues left open even if solved or waiting for more insight. This issue will be closed if no further activity occurs during the next 2 weeks. If the issue is still valid just add a comment to keep it alive. Thank you for your contributions.