go-gl / example

Example programs for the various go-gl packages.
MIT License
223 stars 59 forks source link

Add Glow examples to go-gl/examples. #36

Closed errcw closed 10 years ago

errcw commented 10 years ago

A straight copy from the existing Glow examples. It's unclear to me if I need to do anything to integrate with Travis (e.g., fix data file paths).

dmitshur commented 10 years ago

This Travis script needs to be much improved...

errcw commented 10 years ago

I'm honestly puzzled by the Travis error:

$ go build -v
github.com/go-gl/examples
# github.com/go-gl/examples
./examples.go:19: can't find import: "github.com/go-gl/glow"
The command "go build -v" exited with 2.

As far as I can tell that path is valid and should compile without issue (despite the strangeness of compiling the examples package directly). Any ideas?

dmitshur commented 10 years ago

That is a valid Go package, but it's a command and not library (package name is "main"), so it's not supposed to be imported.

The travis-helper-functions.sh script ends up not downloading glow, hence it can't be imported.

errcw commented 10 years ago

Aha, of course, I'm a little embarrassed I didn't see the error myself immediately. I've fixed the issue and now Travis CI is happy with adding the Glow examples.