Closed dertseha closed 3 years ago
Hm, I could not find 'squash' or 'rebase' button, then I just clicked 'merge' for this PR, but was this fine?
CC @dmitshur
@hajimehoshi It's certainly not a big deal, and comes down to preference. I prefer merging a small PR like this via squash strategy rather than merge strategy, since it adds just 1 commit to git log master
rather than two, which I think leads to a more readable and cleaner history.
This project currently has all 3 merge strategies enabled (merge, squash, rebase), although perhaps that wasn't the case on May 1. You should see them available via a dropdown in the future, like so:
This PR fixes the build status badge (links were wrong)