search

go-gl / gl

Go bindings for OpenGL (generated via glow)
MIT License
1.08k stars 74 forks source link

Make the workflow a bit more reliable #147

Closed Jacalz closed 2 years ago

Jacalz commented 2 years ago

This makes a few changes. Most importantly, it fixes the installation of deps. This was due to the repo list not being updated and partly because apt-get is a terrible package manager (in my opinion) and thus doesn't do it automatically.

The tests now only run for the oldest and newest Go versions only as if it works on both of those, we can literally say that anything between is a bug in Go and not here. Apart from that, it is mostly some clean-ups and updates to the used actions.

However, I saw that there is a no test files here, so the tests actually passing does not give us much reassurance.

errcw commented 2 years ago

Right on, thank you!

dmitshur commented 2 years ago

Thanks!

It's true there aren't dedicated tests in this repo, but it still helps to at least run go test ./... since it confirms there aren't build errors, and runs some high-confidence vet checks. (Plus if a PR comes with tests, they'll be run.) People probably know this, but I wanted to highlight it anyhow.