go-gl / mathgl

A pure Go 3D math library.

BSD 3-Clause "New" or "Revised" License

554 stars 65 forks source link

#48 fixed. VecN with new funcs Set, Vec2, Vec3, Vec4. #49

Closed shogg closed 9 years ago

shogg commented 9 years ago

48 fix + test for mgl32/64.

ghost commented 9 years ago

Can you change the template file so that it generate those changes ? (tests have no templates)

shogg commented 9 years ago

There isn't a template for VecN or is there?

ghost commented 9 years ago

IIRC everything except utils and _test are template generate.

shogg commented 9 years ago

As I said before there is no template. Could somebody please check it?

UserAB1236872 commented 9 years ago

LGTM

dmitshur commented 9 years ago

I'm not sure why Travis did not run on this PR (maybe a configuration issue?).

It's failing on master now because of a vet issue:

$ go tool vet ./
mgl32/matstack/transformstack_test.go:124: ExampleReseed refers to unknown identifier: Reseed
mgl64/matstack/transformstack_test.go:127: ExampleReseed refers to unknown identifier: Reseed

The command "go tool vet ./" exited with 1.

UserAB1236872 commented 9 years ago

Good eye. Not sure what's up with Travis. It used to run on PRs. I reverted this until this is fixed.

dmitshur commented 9 years ago

That failure is unrelated to this PR, so reverting it did not help.

dmitshur commented 9 years ago

Updating to Go 1.5 has fixed the problem, the Travis build succeeds now.

dmitshur commented 9 years ago

I've reapplied the change in 667e7964455c5d0db23927d59cfd72852686e419 (since it was previously reviewed and accepted in this PR, and the build failure is resolved now).