search

go-gl / mathgl

A pure Go 3D math library.
BSD 3-Clause "New" or "Revised" License
554 stars 65 forks source link

Project fix #61

Closed UserAB1236872 closed 8 years ago

UserAB1236872 commented 8 years ago

Fixes #60 (for both 32 and 64). Also appears to change a lot of forward slashes to backslashes in comments, which I think may be a minor bug with our go generate script on Windows? Either way, this is a bug fix so that's probably not worth worrying about.

UserAB1236872 commented 8 years ago

"And go generate" secretly means "and go fmt", but I feel like git commit amending is overkill for that case.

dmitshur commented 8 years ago

"And go generate" secretly means "and go fmt", but I feel like git commit amending is overkill for that case.

Why? Having a nice, clean, readable git history is a good thing.

Also see http://chris.beams.io/posts/git-commit/ on suggestions for how to write better commit messages.

It's not worth after the PR is merged (because that requires force pushing to master branch), but could/should be done before the PR is merged.

UserAB1236872 commented 8 years ago

I don't know, I've heard it's bad form to amend after you push to remote even in a non-master branch, but I probably should have since nobody else was working on the branch.

dmitshur commented 8 years ago

There is absolutely no harm in amending, force pushing, etc., a feature branch that you own. If you happen to be collaborating on that feature branch with someone else, you should coordinate accordingly to avoid losing work, but that's about it.

It's really no different than deleting your feature branch and creating a new one (with same name, or different name). Except it preserves/updates the open PR if you just update the existing branch, which is cleaner.