Drop golang.org/x/image dependency

go-gl / mathgl

A pure Go 3D math library.

BSD 3-Clause "New" or "Revised" License

554 stars 65 forks source link

Drop golang.org/x/image dependency #96

Closed egonelbre closed 11 months ago

egonelbre commented 11 months ago

This uses https://github.com/go-gl/mathgl/pull/95 as the base. So merge the other one before this.

There doesn't seem to be any real benfit from depending on golang.org/x/image, so drop it.

pwaller commented 11 months ago

I've rebased this for you. I agree with the changes. Question: does this have any compatilbility implications?

egonelbre commented 11 months ago

@pwaller I'm not aware that it would. The only scenario would be that someone poking at things via reflect, which seems very unlikely. So, yeah, 99.9% sure it's safe.

dmitshur commented 11 months ago

If we were using type aliases (e.g. type Vec3 = f32.Vec3) then this change would've been a bigger deal. Since we're not, I agree it's reasonable to change its underlying type as done here without much real-world trouble.