search

go-gomail / gomail

The best way to send emails in Go.
MIT License
4.32k stars 572 forks source link

Added an option to manually set filename of attachment #56

Closed slavikm closed 8 years ago

slavikm commented 8 years ago

If the name of the attachment is different the the actual filename on disk, we should have an easy option to change it

slavikm commented 8 years ago

@alexcesaro sorry about the noise with the 2 PRs. I did not see that my teammate already created a PR on the exact same issue.

alexcesaro commented 8 years ago

Thanks, I commented the code.

Please also merge all your commits (I only want one commit at the end) and add an example in example_test.go.

slavikm commented 8 years ago

@alexcesaro Not sure how the examples are being used but see the last commit - squashed and added example.

alexcesaro commented 8 years ago

Thank you! I slightly edited your commit to fix the example.

For your information, rules about naming examples can be found in the documentation of the testing package. And you can see the result in the Gomail documentation.