search

go-goose / goose

goose (Go OpenStack Exchange) - Go bindings for talking to OpenStack.
GNU Lesser General Public License v3.0
17 stars 39 forks source link

Fixed the keystonev3 logic and error messages #72

Closed vinu2003 closed 6 years ago

vinu2003 commented 6 years ago

This PR has code changes that fix the error messages returned from goose library related to authentication and also the fix for scope/Project name being added to auth credentials without checking the tenantId or TenantName.

vinu2003 commented 6 years ago

wallyworld: I have the required test without TenantName and TenantId in the v3userpass_test.go Could u please let me know after taking a look at it. I will wait for ur input. thank u

vinu2003 commented 6 years ago

hi @wallyworld, I agree with your point.However, the Auth() returns AuthDetails which get filled in from v3KeyStoneAuth(). The AuthDetails doesnt have ProjectDomainName. The Logic i have added checks if TenanID or TenantName either of these are set then set ProjectDomainName. If TenantId/Name not there even if credentials has ProjectDomainName it wont be set in auth. Inorder to make things visible i added the ProjectDomain Name in AuthDetails struct and validated it. Kindly let me know your inputs.

vinu2003 commented 6 years ago

openstack auth bugs

vinu2003 commented 6 years ago

openstack auth bugs