search

go-goose / goose

goose (Go OpenStack Exchange) - Go bindings for talking to OpenStack.
GNU Lesser General Public License v3.0
17 stars 39 forks source link

Add project domain id to identity credentials #89

Closed hemanthnakkina-zz closed 3 years ago

hemanthnakkina-zz commented 3 years ago

openrc downloaded from OpenStack horizon for a non-admin user has OS_PROJECT_DOMAIN_ID set but not OS_PROJECT_DOMAIN_NAME.

Project domain ID details are added in Credentials structure.

Fixes: #88

hmlanigan commented 3 years ago

@hemanthnakkina, this looks good, I'm waiting on the using pr, before approving it. autoload-credentials wasn't doing what the QA steps said it should be.

hemanthnakkina-zz commented 3 years ago

@hemanthnakkina, this looks good, I'm waiting on the using pr, before approving it. autoload-credentials wasn't doing what the QA steps said it should be.

Hi I believe you are referring to QA steps in https://github.com/juju/juju/pull/12838. Just want to check if you have downloaded openrc for a non-admin user (or user with role member)?

I am on vacation and will be back on Apr 14th, can provide the exact steps with the output.

SimonRichardson commented 3 years ago

@hmlanigan @hemanthnakkina is this close to merging?

hmlanigan commented 3 years ago

Closing as it's stale now, please reopen when the juju issues have been addressed in the related PR