go-gorm / gorm

The fantastic ORM library for Golang, aims to be developer friendly
https://gorm.io
MIT License
36.03k stars 3.86k forks source link

Additional `.Query` params silently fail if they are used on a raw query #7085

Open pradovic opened 1 week ago

pradovic commented 1 week ago

I have been guilty of using mix of raw query with additional query parameters several times so far. Each time I found out later, during testing, that additional query params were actually not performed, but the query was executed without errors. The example:

       subQuery := `SELECT * from some_table 
        WHERE id = someID
        ORDER BY name`

    query := store.db.Tx(ctx).Raw(subQuery, params)

    if  someLogic {
        query = query.Where("additional_param= ?", additionalParam)
    }

    err = query.Find(&entities).Error

if someLogic is true, this query is executed without error, but the where clause is not executed.

Motivation

I think it would be great to either error out, or support adding the parameter at the correct place in the raw query. Let me know if this makes sense. I would be open on working on this as well (creating a PR).

github-actions[bot] commented 1 week ago

The issue has been automatically marked as stale as it missing playground pull request link, which is important to help others understand your issue effectively and make sure the issue hasn't been fixed on latest master, checkout https://github.com/go-gorm/playground for details. it will be closed in 30 days if no further activity occurs. if you are asking question, please use the Question template, most likely your question already answered https://github.com/go-gorm/gorm/issues or described in the document https://gorm.ioSearch Before Asking