go-gorm / gorm

The fantastic ORM library for Golang, aims to be developer friendly
https://gorm.io
MIT License
36.03k stars 3.86k forks source link

feat: Modernize Docker Compose File #7086

Open isso-719 opened 1 week ago

isso-719 commented 1 week ago

What did this pull request do?

This pull request did the following

Rename the file from docker-compose.yml to compose.yml .

The file name compose.yml is preferred. https://docs.docker.com/compose/compose-application-model/#the-compose-file

Remove version top-level element on compose.yml .

Version top-level element is obsoleted. https://docs.docker.com/compose/compose-file/04-version-and-name/#version-top-level-element-obsolete

When run test, system shows warning.

tests % ./tests_all.sh
WARN[0000] /Users/john/gorm/tests/docker-compose.yml: `version` is obsolete
...

Changed command used from docker-compose to docker compose.

The recommended command-line syntax is docker compose. https://docs.docker.com/compose/migrate/#what-are-the-differences-between-compose-v1-and-compose-v2

Change related files.

docker-compose start => docker compose start docker-compose up => docker compose up

User Case Description

jinzhu commented 5 days ago

It seems that docker-compose is still an alias of docker compose in the new version. Let's keep it for better compatibility.

isso-719 commented 5 days ago

It seems that docker-compose is still an alias of docker compose in the new version. Let's keep it for better compatibility.

@jinzhu Thank you for your reply. For compatibility, I reverted from the docker compose command to the docker-compose command.

Please check Files changed. Thank you.