go-gorm / gorm

The fantastic ORM library for Golang, aims to be developer friendly
https://gorm.io
MIT License
37.05k stars 3.94k forks source link

Join clause does not implement the clause interface #7188

Closed gregorgebhardt closed 1 month ago

gregorgebhardt commented 2 months ago

GORM Playground Link

I tried to but running the test.sh in the playground repo returns the error:

go: gorm.io/playground imports
        gorm.io/gen/examples: cannot find module providing package gorm.io/gen/examples

Description

When trying to add a join clause to my query via clause.Join{...} and later

sqlQuery := db.WithContext(ctx).Model(...)
sqlQuery.Clauses(joinClause)

The join ends up in a WHERE condition. The problem is that within the function func (db *DB) Clauses(conds ...clause.Expression) (tx *DB), there is a type switch on the elements in conds. But since clause.Join neither implements the clause.Interface nor the StatementModifier, it will be put into the whereConds slice and ends up in the WHERE conditions...

github-actions[bot] commented 2 months ago

The issue has been automatically marked as stale as it missing playground pull request link, which is important to help others understand your issue effectively and make sure the issue hasn't been fixed on latest master, checkout https://github.com/go-gorm/playground for details. it will be closed in 30 days if no further activity occurs. if you are asking question, please use the Question template, most likely your question already answered https://github.com/go-gorm/gorm/issues or described in the document https://gorm.ioSearch Before Asking