search

go-gorm / gorm

The fantastic ORM library for Golang, aims to be developer friendly
https://gorm.io
MIT License
37.05k stars 3.94k forks source link

Use official SQL Server docker image for tests #7205

Closed omkar-foss closed 1 month ago

omkar-foss commented 2 months ago

What did this pull request do?

This replaces the community SQL Server docker image (https://hub.docker.com/r/mcmoe/mssqldocker) with the official one (https://hub.docker.com/r/microsoft/mssql-server).

User Case Description

This is an attempt to fix the failing SQL Server workflow in GitHub actions (example here).

iTanken commented 2 months ago

My modification in go-gorm/sqlserver#142 passed the test, which can be for reference.

omkar-foss commented 2 months ago

This PR is now ready for review, kindly review and let me know if any further changes are required. Thank you!