go-gorm / gorm

The fantastic ORM library for Golang, aims to be developer friendly
https://gorm.io
MIT License
37.02k stars 3.94k forks source link

Field Overwriting Issue with Embedded Structs in GORM #7237

Closed TalesPalma closed 1 month ago

TalesPalma commented 1 month ago

GORM Playground Link

https://github.com/go-gorm/playground/pull/1

Description

When using GORM to map structs to a database, an issue arises when embedding structs that have fields with the same name as those in the outer struct. Specifically, when embedding an Author struct within a Food struct, if both structs contain a field named Name, only the outer struct's field (Food.Name) is saved to the database, while the embedded struct's field (Author.Name) is ignored.

Example Code:


package main

import (
    "gorm.io/driver/sqlite"
    "gorm.io/gorm"
    "log"
)

type Author struct {
    gorm.Model
    Name  string `json:"name" gorm:"not null"`
    Email string `json:"email" gorm:"not null"`
}

type Food struct {
    gorm.Model
    Name          string `json:"name" gorm:"not null"`
    Price         string `json:"price" gorm:"not null"`
    Calories      string `json:"calories"`
    Proteins      string `json:"proteins"`
    Fats          string `json:"fats"`
    Carbohydrates string `json:"carbohydrates"`
    Sodium        string `json:"sodium"`
    Author        Author `json:"author" gorm:"embedded"`
}

func main() {
    db, err := gorm.Open(sqlite.Open("food.db"), &gorm.Config{})
    if err != nil {
        log.Fatalf("failed to connect to the database: %v", err)
    }

    // Auto-migrate the Food and Author structs to create the necessary tables
    if err := db.AutoMigrate(&Food{}); err != nil {
        log.Fatalf("failed to migrate: %v", err)
    }

    // Create a new Food item with an embedded Author
    food := Food{
        Name: "Pasta",
        Author: Author{
            Name:      "Chef Mario",
            Biography: "A renowned chef known for Italian cuisine.",
        },
    }

    // Save the food item to the database
    if err := db.Create(&food).Error; err != nil {
        log.Fatalf("failed to create food item: %v", err)
    }

    log.Println("Food item created successfully!")
}
github-actions[bot] commented 1 month ago

The issue has been automatically marked as stale as it missing playground pull request link, which is important to help others understand your issue effectively and make sure the issue hasn't been fixed on latest master, checkout https://github.com/go-gorm/playground for details. it will be closed in 30 days if no further activity occurs. if you are asking question, please use the Question template, most likely your question already answered https://github.com/go-gorm/gorm/issues or described in the document https://gorm.ioSearch Before Asking