go-gorm / postgres

GORM PostgreSQL driver
MIT License
228 stars 120 forks source link

added 23503 pgerrcode support and updated the error conversion approach #185

Closed amirejaz75 closed 1 year ago

amirejaz75 commented 1 year ago

What did this pull request do?

Added 23503 pgerrcode support and updated the error conversion from pg error to gorm error approach

User Case Description

saeidee commented 1 year ago

You may have conflict after merging this https://github.com/go-gorm/postgres/pull/179

saeidee commented 1 year ago

@jinzhu could you please revert this, as it has not properly resolved the conflict with this https://github.com/go-gorm/postgres/pull/179 as well as needs to update gorm version to have the new error type.

image
watson-sam commented 1 year ago

@saeidee just opened an issue (https://github.com/go-gorm/postgres/issues/187) as hadnt seen yout above comment but this is indeed causing an error

jinzhu commented 1 year ago

@jinzhu could you please revert this, as it has not properly resolved the conflict with this #179 as well as needs to update gorm version to have the new error type. image

Can you submit the revert commit and release a new version?

(I haven't something wrong with my development machine ;(

saeidee commented 1 year ago

@codingamir feel free to create a new PR & thanks for contributing.