search

go-gorm / postgres

GORM PostgreSQL driver
MIT License
225 stars 119 forks source link

update gorm to master latest #242

Closed black-06 closed 6 months ago

black-06 commented 6 months ago

for https://github.com/go-gorm/gorm/pull/6386

What did this pull request do?

We must update gorm

User Case Description

Gorm must be upgraded, current v1.5.5 is not compatible.

It makes more sense to remove the tag.

Wait for the Gorm upgrade to complete, and then re-upgrade the postgres driver.

If we decide to do so, we can close this mr.

jasonchuan commented 6 months ago

gorm dependency to driver is ok , driver dependency to gorm(except interface) is not best, choice,should we consider it more?

black-06 commented 6 months ago

gorm dependency to driver is ok ,but the implementation of driver dependency to gorm is not best, choice,should we consider it more?

I agree, but it seems that #195 must depends on https://github.com/go-gorm/gorm/pull/6386, that's a breaking change, just like https://github.com/go-gorm/mysql/pull/123.

But I foolishly forgot to remind jinzhu about this.

black-06 commented 6 months ago

I've deleted tag v1.5.5. Next we need to discuss rollback, or how to fix it.

jasonchuan commented 6 months ago

I've deleted tag v1.5.5. Next we need to discuss rollback, or how to fix it.

We appreciate your hard work！ we shoud fand another way to fix it ,it is not easy