search

go-gorm / postgres

GORM PostgreSQL driver
MIT License
225 stars 119 forks source link

Revert "refactor: distinguish between Unique and UniqueIndex (#195)" #248

Closed jasonchuan closed 6 months ago

jasonchuan commented 6 months ago

This reverts commit 1cfbc8652cd8c56d1cd05c1a3e111318b3dd551d.

What did this pull request do?

we shoud revert the code ,and then add a tag v1.5.5 ,so that the issues can be resolved https://github.com/go-gorm/postgres/issues/247 https://github.com/GenerateNU/sac/pull/157 https://github.com/go-gorm/gorm/issues/6821 etc

@jinzhu @black-06

User Case Description

black-06 commented 6 months ago

Then release a new version to retract v1.5.5?

retract (
    v1.5.5 // Published accidentally.
    v1.5.6 // Contains retractions only.
)

but we can do it directly on the current master. the related code in GORM has been merged into the master, it means that even if #195 is revert now, it still needs to merge into the master

jasonchuan commented 6 months ago

Then release a new version to retract v1.5.5?

retract (
    v1.5.5 // Published accidentally.
    v1.5.6 // Contains retractions only.
)

but we can do it directly on the current master. the related code in GORM has been merged into the master, it means that even if #195 is revert now, it still needs to merge into the master

should go.mod go.sum should be revert at the same time ! to avaid accident ,we close this mr , consider it carefully before making decision.