search

go-gorm / postgres

GORM PostgreSQL driver
MIT License
225 stars 119 forks source link

fix: retract v1.5.5 #249

Closed black-06 closed 6 months ago

black-06 commented 6 months ago

What did this pull request do?

247, only delete tag v1.5.5 is not enough.

If we accept this mr, we need to publish v1.5.6 to retract v1.5.5 (& v1.5.6)

User Case Description

jinzhu commented 6 months ago

Can you publish the v1.5.6 tag？

black-06 commented 6 months ago

I don't known how to only publish tag.... I only known I can publish a new release with new tag...

J-Rocke commented 6 months ago

@black-06 I think publishing a new release with the new tag is fine. It could also help to explain what happened to people running into this. From the go module side publishing the git tag without a github release is the same as doing a release with the tag.

J-Rocke commented 6 months ago

On the commandline you checkout the branch/commit you want to tag and then run: git tag v1.5.6 to create the tag and then git push refs/tags/v1.5.6 to push it to github.

black-06 commented 6 months ago

On the commandline you checkout the branch/commit you want to tag and then run: git tag v1.5.6 to create the tag and then git push refs/tags/v1.5.6 to push it to github.

yes I known if i push the git tag to github，it will create a tag without release.

But what surprised me was that 1.5.5 wasn't pushed by me, it seemed like it was automatically generated, or someone else did it on the page

J-Rocke commented 6 months ago

Sorry i misundestood your question. I would assume someone else did push the tag. Maybe you can check some log in github to find out who pushed it.
Or the person who deleted the tag maybe knows since github shows who pushed which tag.

black-06 commented 6 months ago

Sorry i misundestood your question. I would assume someone else did push the tag. Maybe you can check some log in github to find out who pushed it. Or the person who deleted the tag maybe knows since github shows who pushed which tag.

I deleted the tag, but that tag shows that I pushed it, just like https://github.com/go-gorm/mysql/releases/tag/v1.5.3. But I know I didn't...

J-Rocke commented 6 months ago

Yeah that is strange and you should figure out why that happened. Is there any reason to not publish the v1.5.6 now?

black-06 commented 6 months ago

Yeah that is strange and you should figure out why that happened. Is there any reason to not publish the v1.5.6 now?

Aha, jinzhu manually pushed the tag.

Okay, I publish it now.