go-gorm / sqlite

GORM sqlite driver
MIT License
179 stars 184 forks source link

🐛 fix logic of parsing multiple columns (i.e. for PRIMARY KEYS, CONSTRAINT) #193

Closed Shion1305 closed 1 month ago

Shion1305 commented 2 months ago

Description

This PR is a partial fix for issue #192.

Bug Descriptions:

Changes Introduced

Additional Notes:

The second bug (handling of column names with commas) will be addressed in a separate PR, which is still in progress.

Reference

SQLite implements its escaping logic as follows: https://github.com/sqlite/sqlite/blob/cf25c16a54f68d1ca095b91bd0ead840578b2bb4/ext/fts3/fts3.c#L464-L486

User Case Description

Refer test cases.

Shion1305 commented 1 month ago

@jinzhu Hi! Is there any change you could review this PR? Thanks in advance 🙏