Optimized InnerJoin by indexing the dataframe key with a map.

go-gota / gota

Gota: DataFrames and data wrangling in Go (Golang)

Other

3.04k stars 281 forks source link

Optimized InnerJoin by indexing the dataframe key with a map. #32

Closed claudiofahey closed 5 years ago

claudiofahey commented 7 years ago

InnerJoin of 100,000 rows with 100,000 rows went from 15 minutes to about 1 second. Similar optimizations can be done with Left and Right join.

wolfeidau commented 6 years ago

Are you planning to update this PR @claudiofahey ?

I would love to continue this work optimising this library.

kniren commented 6 years ago

Hey @wolfeidau I think it's safe for you to pick this task up, since he had not answered to this issue at all so far. Thank you for your interest in the project, can't wait to see your PR!

danicat commented 5 years ago

Since this has been inactive for quite a long time I'm closing this down. If anyone is willing to continue this work please open a new PR targeting the dev branch.

imthaghost commented 2 years ago

Did this optimization ever make it out of testing?

chrmang commented 2 years ago

Hi @imthaghost ,

this PR is still not merged - it was closed due to inactivity.

I didn't see any benchmark results comparing the modifications to current code.