search

go-gota / gota

Gota: DataFrames and data wrangling in Go (Golang)
Other
2.98k stars 277 forks source link

Implement MapFunc method to support function application over Series Elements #48

Closed szaydel closed 5 years ago

szaydel commented 6 years ago

I am not sure if you find this in any way interesting. I am still planning to PR other bits, like the Histogram, but wanted to give it a bit more time and thought. I found having a mapping method that does not affect length of series useful, and while perhaps this is not the best implementation, if you think you have interest, I am sure given feedback we can make it better.

Thanks for considering this changeset. Cheers.

szaydel commented 6 years ago

I think this sounds quite reasonable really. I feel like it is limiting in some ways to do this, but it does reduce the size of that worm can you mentioned. Let me give this a bit more thought and perhaps I will have a better alternative, otherwise given your suggestion will you consider merging it in, or do you feel value is not there, or not in line with what you see for this package? Thanks!

szaydel commented 6 years ago

I think you are right about this one. I am going to go ahead make changes and make sure it feels OK, and add some tests.

szaydel commented 6 years ago

I created a new PR with another version of this based on your suggestions. Perhaps we can just resolve this issue since I used a different branch and target dev this time instead of master?

Thanks!

danicat commented 5 years ago

@szaydel since you've already proposed a different solution in #57 I'm closing this one.