search

go-gota / gota

Gota: DataFrames and data wrangling in Go (Golang)
Other
2.98k stars 276 forks source link

Dev circleci changes #79

Closed rickypereira closed 5 years ago

rickypereira commented 5 years ago

Rolling in changes for have CircleCI up and running. The CircleCI config file is rough sketch of what I am thinking, missing only uploading codecov. I also currently do not have permissions to create a project in CircleCI (so I can't test this config file).

I also used dep build a gopkg.toml file: if we are going to reply on dependency (even though it is just gonum right now), I thought this would be an easy way to see what we are using.

I also changed the organization name from kniren to go-gota.

kniren commented 5 years ago

Hi,

I hope everyone gets these emails, please confirm.

I give permission to CircleCI to access the project. Please make sure that in your PR is only a single change/feature. You have mixed the CI stuff and the typo corrections which makes it difficult to review.

I’m currently traveling to Brazil for a month and will have limited access to internet but I will try my best to keep up with this. Please ask for the feedback of the other members of the organization for the PRs and the work you are doing so that we don’t duplicate efforts.

Best, Alex

On Tue, 12 Feb 2019 at 03:19, Rick notifications@github.com wrote:

@Rpereira23 https://github.com/Rpereira23 requested your review on: #79 https://github.com/go-gota/gota/pull/79 Dev circleci changes.

— You are receiving this because your review was requested.

Reply to this email directly, view it on GitHub https://github.com/go-gota/gota/pull/79#event-2132422968, or mute the thread https://github.com/notifications/unsubscribe-auth/ABm4Os0OhdmgYsJ2KwPHI2RR11bQCoC3ks5vMiSvgaJpZM4a1dW4 .

rickypereira commented 5 years ago

@kniren I attached an image of what I see when I try to add a project below. The "Contact repo admin" lock is typically where I can add a project.

In regards to the PR: should I close this one and separate them into different PRs?

screen shot 2019-02-12 at 10 11 23 am
kniren commented 5 years ago

I'm not familiar with this CI environment so I'm afraid I can't help you. I think before committing to it you should test the CI in a private repository of yours so that you can experiment with it with less friction.

Regarding the PR i suggest you to look at the merged and closed PRs so that you are aware of the procedure, but in this case I would say, transform the current PR into one with just the typo fixing until you are confident about how to set up the CI.

To the rest of the team I would ask to reply to this email so that I know you are receiving the notifications for this thread.

Best, Alex

On Tue, Feb 12, 2019, 12:15 Rick <notifications@github.com wrote:

@kniren https://github.com/kniren I attached an image of what I see when I try to add a project below.

In regards to the PR: should I close this one and separate them into different PRs?

[image: screen shot 2019-02-12 at 10 11 23 am] https://user-images.githubusercontent.com/15759230/52645417-bb1df280-2eae-11e9-8e02-676daca5935e.png

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/go-gota/gota/pull/79#issuecomment-462798477, or mute the thread https://github.com/notifications/unsubscribe-auth/ABm4OuOAGEdFjEZYaRfkotytKLs0TRqpks5vMtqIgaJpZM4a1dW4 .