search

go-gota / gota

Gota: DataFrames and data wrangling in Go (Golang)
Other
3.04k stars 281 forks source link

Removing panic from fileType #89

Closed kellrott closed 5 years ago

kellrott commented 5 years ago

Now the default type will be used, rather then stopping the program

danicat commented 5 years ago

LGTM

danicat commented 5 years ago

@kellrott thanks for your contribution! I just changed your PR to merge to dev instead of master since its where all our development happens. We only merge to master from dev once we have a stable release.

danicat commented 5 years ago

I'm sorry, I had to revert this as my tentative of merge introduced some unintentional changes to the dev branch. Could you rebase your branch on dev and submit a new PR? (There is probably a clever way to solve this, but it's 1:30 am and my brain is basically dead... lol... I shouldn't be merging stuff at this time of the day anyway)