search

go-gota / gota

Gota: DataFrames and data wrangling in Go (Golang)
Other
2.98k stars 276 forks source link

Merged master and added missing closing brace #98

Closed chrstphlbr closed 4 years ago

jdgiotta commented 4 years ago

@chrstphlbr is dev branch still considered active? There seems to be a bit of drift between dev and master

chrstphlbr commented 4 years ago

I am not sure, just read in another PR that it should target dev instead of master, hence I am sending my PRs to it. Also I had a previous PR accepted to dev, which would indicate that it is some sorts of active.

kniren commented 4 years ago

Thanks for the commit!

I just performed a merge from dev into master and fix a couple of issues (The missing bracket was in there as well).

Master and dev should be aligned now, and the current version v0.10.1 is the most recent release branch.

Sorry that I didn't see this PR in time, initially I was only going to bump the release number and didn't realize there was a couple of bugs in the dev branch. Once I found the bugs I tried to squash them right away.

I really appreciate your time, and I know that it can be frustrating to find out that a change you proposed months ago was just ignored.

Once again, I apologize for this.