go-graphite / buckytools

Go implementation of useful tools for dealing with Graphite's Whisper DBs and Carbon hashing
Other
19 stars 8 forks source link

rebalance: use -metrics-per-second when resetting sync speed with health check #29

Closed bom-d-van closed 2 years ago

bom-d-van commented 2 years ago

Before this change, if go-carbon health check is enabled, when go-carbon cache.size overflows, buckytools reset sync speed to 1 metrics-per-second and there is no way to adjust it. This is not ideal if a go-carbon box always has cache.size limit over the safety threshold due to file system fragmentation or aging ssd.

With this change, it allows to have an adjustable minimum sync speed.

deniszh commented 2 years ago

Probably we need to cut another release after merging this too.

bom-d-van commented 2 years ago

Yep, thanks for the approval and reminder, Denis. Merging it. :)