search

go-graphite / carbon-clickhouse

Graphite metrics receiver with ClickHouse as storage
MIT License
187 stars 47 forks source link

Add mTLS support for upload to ClickHouse #121

Closed sheyt0 closed 1 year ago

sheyt0 commented 1 year ago

Hello! Is it possible to add support for client TLS certificates and (as result) mTLS authentication for upload to ClickHouse?

Civil commented 1 year ago

@msaf1980 that's funny coincidence as we were discussing demand for TLS and mTLS on carbonapi side just recently (as part of https://github.com/go-graphite/carbonapi/pull/742 ).

msaf1980 commented 1 year ago

Hello! Is it possible to add support for client TLS certificates and (as result) mTLS authentication for upload to ClickHouse?

Possible in the future. After implement on carbonapi, reuse them in carbon-clickhouse for upload/graphite-clickhouse for read.

sheyt0 commented 1 year ago

Possible in the future. After implement on carbonapi, reuse them in carbon-clickhouse for upload/graphite-clickhouse for read.

Nice to hear. I'll wait. Thanks!

zostrich commented 1 year ago

Hello! How soon will TLS support be implemented?

Felixoid commented 1 year ago

As soon as somebody will need it so much, so will add it

msaf1980 commented 1 year ago

We planned to add it, may be in two month, if have some free time.

zostrich commented 1 year ago

will be great! much needed thing

msaf1980 commented 1 year ago

@sheyt0 Already in master. Can you test from master or will be wait next release ?

msaf1980 commented 1 year ago

v0.11.7 is released. Reopen the issue if you have are problem with this feature,