search

go-graphite / carbon-clickhouse

Graphite metrics receiver with ClickHouse as storage
MIT License
186 stars 48 forks source link

Support for timestamp as -1 #25

Closed agend closed 5 years ago

agend commented 5 years ago

Hi We use -1 as value for timestamp (it is valid according to https://graphite.readthedocs.io/en/latest/feeding-carbon.html ) but carbon-clickhouse set it to 4294967295 (max value for uint32). I have checked https://github.com/lomik/carbon-clickhouse/blob/master/receiver/plain.go#L77 and in case of -1 it will overflow when conversion to uint32 will be performed. Should I prepare MR?

lomik commented 5 years ago

Should I prepare MR?

I don't mind :)

agend commented 5 years ago

@lomik Will you release version any time soon?)

lomik commented 5 years ago

@lomik Will you release version any time soon?)

Not yet planned. Too few changes from previous release.