search

go-graphite / carbon-clickhouse

Graphite metrics receiver with ClickHouse as storage
MIT License
186 stars 47 forks source link

Telegraf HTTP JSON receiver combines the measurement and field with an underscore #46

Closed Hipska closed 3 years ago

Hipska commented 5 years ago

It seems that when using Telegraf HTTP JSON receiver, the measurement name and field name are combined with an underscore. When configuring Telefgraf to send data as graphite output to carbon-clickhouse, they are combined with a dot. The dot is in my opinion also more logical.

I use the http transport as it seems smaller in size when compared to the graphite transport. (especially when using tags a lot)

lomik commented 4 years ago

I'm trying to maintain naming compatibility with Prometheus. Dot is disallowed in Prometheus

Hipska commented 4 years ago

We are talking about graphite, no? Also, in what way is this breaking compatibility with Prometheus?

Could you please make this configurable then?

lomik commented 4 years ago

We are talking about graphite, no?

carbon-clickhouse, graphite-clickhouse can be used as long term storage for Prometheus. Moreover graphite-clickhouse has a built-in Prometheus web interface and can be used in Grafana as data source with prometheus protocol.

Could you please make this configurable then?

I don't mind. PR are welcome

Hipska commented 4 years ago

I'm sorry, I don't have much to zero experience with Go. Don't know where to start.

Hipska commented 3 years ago

@lomik I tried to implement this with a config option, but got lost on how or where I should pick on. Everything seems to be extracted away so much. Could you give me any pointers please?

Hipska commented 3 years ago

I think I found a solution (#83), let me know what you think of it.