go-graphite / carbon-clickhouse

Graphite metrics receiver with ClickHouse as storage
MIT License
186 stars 48 forks source link

readme suggests to use graphite_index but default config is generated with graphite_tree #82

Open kt97679 opened 3 years ago

kt97679 commented 3 years ago

Hello.

README.md has guidelines to setup graphite_index table and use it in the config of the carbon-clickhouse. From what I see carbon/config/go uses graphite_tree instead. Default config generated by carbon-clickhouse is not using graphite_index as well. README.md for the graphite-clickhouse has a note that graphite_tree is deprecated.

May I ask you to clarify what table should be used: graphite_index or graphite_tree?

Thanks!

Felixoid commented 3 years ago

Hey, the readme is correct, index table should be used https://github.com/lomik/graphite-clickhouse/wiki/IndexTable

It makes sense for sure to change the defaults

kt97679 commented 3 years ago

Thanks a bunch for the clarification @Felixoid !

Felixoid commented 3 years ago

After merging https://github.com/lomik/graphite-clickhouse/pull/157 I'll rework the config for carbon-clickhouse as well