search

go-graphite / carbonapi

Implementation of graphite API (graphite-web) in golang
Other
309 stars 140 forks source link

functions: check applyByNode field overflow #745

Closed msaf1980 closed 1 year ago

msaf1980 commented 1 year ago

applyByNode don't check field argument overflow. This PR change this and return name tag for this.

It's disputable - graphite-web also don't check this. But it's a error and produce a panic due out of range.

https://github.com/graphite-project/graphite-web/blob/90076f6c60060399a6a3ce0ffc929a1ccc086325/webapp/graphite/render/functions.py#L5105

msaf1980 commented 1 year ago

PR updated for coexists with graphite-web (https://github.com/graphite-project/graphite-web/pull/2792)