Closed evdevk closed 1 year ago
This might be a bug, potentially introduced here https://github.com/go-graphite/carbonapi/commit/d77e3ee963f7262ee852034f6fdcfa27663bca92#diff-fce0198985d6dad323115ac9f864bab245cb25e6b06dd228c901e92e6a590b71
The CopyTag
call is overriding the tags
However, it looks like that was introduced in v0.16.0-patch1
. You say this happens in v 0.15.6
and later ?
However, it looks like that was introduced in
v0.16.0-patch1
. You say this happens inv 0.15.6
and later ?
I have a build which say on the start in journalctl v0.15.6-296-g0bb2. but is there already. v 0.15.5 working as intended. I tried also latest versions 0.16.X - bug was there also.
I've submitted a PR that should solve the issue.
this bug is still around in latest 0.16.1 https://packagecloud.io/go-graphite/autobuilds/packages/el/8/carbonapi-0.16.1~10+sha.gea3cf7-1.x86_64.rpm?distro_version_id=205
additional info:
typical request without alias like:
seriesByTag('name=system.system.load5', 'host=server1234')
works ok. response tags array looks like:
tags:Object
contur:"prod"
host:"server1234"
interval:"15s"
ostype:"linux"
this one are without tags:
groupByTags(seriesByTag('name=system.system.load5', 'host=server1234'), 'max', 'host')
tags:Object
host:"server1234"
name:"max"
with older versions 0.15.5 works ok.
requested new bug here https://github.com/go-graphite/carbonapi/issues/808
Problem description Have been used carbonapi for requests from grafana to clickhouse server (graphite-clickhouse inbetween). After update to newer version noticed what response json become different
Old version request (working as inteded):
Old version response (working as inteded):
New version request is the same as older version. New version response also the same. BUT if I put to a request aliasByTags function - tags object in response are different for old and new versions.
Request:
Old version response:
New version response:
in my case tags list are matter. How can I return back old tags oject result? any config options?
carbonapi's version v 0.15.6 and later - working with issue. tried different versions, newest included v 0.15.5 and less - working as intended
Does this happened before No. After
carbonapi's config Both versions have the same config file:
backend software and config graphite-clickhouse 0.12.0 clickhouse-server 22.8.4.7 (official build)
carbonapi performance metrics
Query that causes problems
Additional context