go-graphite / carbonapi

Implementation of graphite API (graphite-web) in golang
Other
308 stars 140 forks source link

`currentAbove` and similar to do '>' and not '>=' #784

Closed npazosmendez closed 1 year ago

npazosmendez commented 1 year ago

The xAbove functions should not include series that match by =. I.e., the filtering should be by > and not by >=.

This is consistent with Graphite Web. See currentAbove (link) and all similar xAbove functions.

I don't know why the isInclusive bool was there originally. I checked GraphiteWeb and it never does that. I also looked at the original PR here introducing this function, and I see no specific references to this.