search

go-graphite / carbonapi

Implementation of graphite API (graphite-web) in golang
Other
308 stars 140 forks source link

fix return code for render_handler #789

Closed Thorsieger closed 5 months ago

Thorsieger commented 1 year ago

Hello,

carbonapi do not response correct code 404 when no metric is found from gocarbon/carbonserver when requesting for a render

This should fix the issue :

returnCode is reasigned in an other scope, so any modification won't have effect ouside the if

msaf1980 commented 11 months ago

Hello,

carbonapi do not response correct code 404 when no metric is found from gocarbon/carbonserver when requesting for a render

This should fix the issue :

returnCode is reasigned in an other scope, so any modification won't have effect ouside the if

@Civil May be extend e2e tests for check status code ? Some of them are cheched, but this case not.