search

go-graphite / carbonapi

Implementation of graphite API (graphite-web) in golang
Other
308 stars 140 forks source link

expr: clean from direct use zipper/limiter from carbonapi app global config #811

Closed msaf1980 closed 4 months ago

msaf1980 commented 7 months ago

Try to refactor expr package for avoid direct usage zipper/limiter from carbonapi app global config. Not a complete refactor, no separate Eval/Fetch (may be in future).

msaf1980 commented 5 months ago

Reason for do this - use expr methods in separate product. Use for configure it with carbonapi app config is bad design.

msaf1980 commented 5 months ago

@npazosmendez Another variant of expr refactor. It's compromise (global evaluator exist, but only in expr). May be less clear, but more simple and no Do changes is required.

msaf1980 commented 5 months ago

Not complete solution. https://github.com/go-graphite/carbonapi/pull/818 solved more problems, but required functions Do signature change

There's other cases that are even more tricky, or maybe even impossible. For example aliasQuery