search

go-graphite / carbonapi

Implementation of graphite API (graphite-web) in golang
Other
308 stars 140 forks source link

Update all vendored dependencies #831

Closed Civil closed 3 months ago

Civil commented 3 months ago

One small change was required - for irondb, Discover config option was removed at some point. Commented it out.

Hipska commented 1 month ago

May I ask why the modules are also included in the vendor dir? This isn't a usual practice with most other go applications.

Civil commented 1 month ago

Historical reasons. That project predates modules and during early days having all dependencies in the repo was the mainstream way to go. It have some small benefits - e.x. it guarantees that build will be reproducible and original dev won't disable that with force-push or something.