search

go-graphite / carbonzipper

proxy to transparently merge graphite carbon backends
Other
104 stars 29 forks source link

investigate if it's possible to remove stopTime from responses #58

Closed Civil closed 6 years ago

Civil commented 6 years ago

It seems that it's very easy to reconstruct stopTime out of data we receive. Is there any real need in having that in protocol?

Civil commented 6 years ago

@dgryski do you have any opinion about that? Maybe you remember the original reasoning behind having that in a first place?

dgryski commented 6 years ago

The original reasoning was probably due the protobuf to match the pickle, which had that field. If you remove it remember you're going to need an upgrade path: first set consumers to always calculate it, then afterwards set the servers to stop sending it.

Civil commented 6 years ago

I think it's not worth to remove it. With new protocol messages it should be possible to convert them directly into pickle and almost directly to json