search

go-graphite / go-carbon

Golang implementation of Graphite/Carbon server with classic architecture: Agent -> Cache -> Persister
MIT License
805 stars 123 forks source link

Next release date #333

Open dcharleston opened 4 years ago

dcharleston commented 4 years ago

Hello, apologies if this is the wrong place to ask but I was wondering when the next release would be. I assume the master branch is not considered stable but we'd like use a recently merged feature.

azhiltsov commented 4 years ago

What recent feature are you interested in? I can provide you some insights about stability.

dcharleston commented 4 years ago

I'm primarily interested in using the max-metrics-rendered parameter

azhiltsov commented 4 years ago

That part can be considered safe to use, we are running both trie and trigram indexes in production for a while now. We should cut the release when we finish testing for compressed whisper (but our current priorities somewhere else)

deniszh commented 4 years ago

SOON ™️

akamensky commented 4 years ago

And I am interested in compression feature. 116 commits since last release and over a year of time.

deniszh commented 4 years ago

No worries, we'll make release really soon. But as far as I know both trie index and compressed whisper still has own edge cases btw. Am I right, @bom-d-van @azhiltsov ?

bom-d-van commented 4 years ago

To my knowledge, trie index should be working fine (just in case, the other working MR is a new feature for trie index), @azhiltsov might have more input and production knowledge.

For compression, there is indeed a reported edge case. Should only affect single level retention policy with repeating timestamps. I think I could make a fix soon. Overall, compression should be working fine, and more people testing and using it could help us maturing it.

azhiltsov commented 4 years ago

Compressed whisper did not work for us and we don't use it in production.

I think we can include compression to release with default to disabled, Mention that it current state is EXPERIMENTAL (config and front page) and Explain expected producer behavior which known to work (fully in order datapoints without attempts to backfill)

deniszh commented 4 years ago

Cool, thanks @azhiltsov for production experience, much appreciated! That was my original intention - release trie and cwisper as EXPERIMENTAL features, which require more testing.

akamensky commented 4 years ago

Thanks for the info. We use UDP. So order is not guaranteed. Good to know there may be issues if use compression.

deniszh commented 4 years ago

Not sure if UDP will affect cwisper that much, but it needs testing, indeed.