search

go-graphite / go-carbon

Golang implementation of Graphite/Carbon server with classic architecture: Agent -> Cache -> Persister
MIT License
801 stars 126 forks source link

fix(carbonserver): find http/grpc - fix metrics_found metric #521

Closed timtofan closed 1 year ago

timtofan commented 1 year ago

Approved. But just as an opinion, I think we might be able to call listener.populateMetricsFoundStat even when there is a loop which does something else as well. It's cleaner but might cause less performance but I don't think that's much. So your call.

yes I was thinking about it, guess it shouldn't really affect performance, lemme update

timtofan commented 1 year ago

@emadolsky updated