go-graphite / go-carbon

Golang implementation of Graphite/Carbon server with classic architecture: Agent -> Cache -> Persister
MIT License
801 stars 126 forks source link

cleanup: remove <requestType>Errors metrics in favour of status_codes.* ones as more reliable #523

Closed timtofan closed 1 year ago

timtofan commented 1 year ago

In our clusters FindErrors erroneously showed zero while there were lots of http404s. In general those metrics are less reliable than status_codes.* ones since they depend on having code to increment it on each error scenario which is easy to miss.