go-graphite / go-carbon

Golang implementation of Graphite/Carbon server with classic architecture: Agent -> Cache -> Persister
MIT License
801 stars 126 forks source link

[Q] New release date #535

Closed cboudereau closed 1 year ago

cboudereau commented 1 year ago

Is it possible to bump a new release since the v0.16.2 is a bit aged and the master example conf crashes with this error : FATAL [main] failed to stat whisper data directory: lstat /var/lib/graphite/whisper: no such file or directory {}

Linked to this one from 2020 : https://github.com/go-graphite/go-carbon/issues/333

Is it possible to have regular release like every X months ?

deniszh commented 1 year ago

Sure, let me create release tomorrow. We're using master in production, so, release schedule is irregular. We can do releases by schedule, that's only matter of discipline :)

cboudereau commented 1 year ago

Thanks a lot!

deniszh commented 1 year ago

But please note that error above is valid and not a crash - go-carbon can't read configured whisper directory.

cboudereau commented 1 year ago

Ok but the question is why it is working with the same conf and the master version?

I also double check that the go function os.Lstat and the fact that the directory exists in the container for carbon user

cboudereau commented 1 year ago

I did not dig further but it seems that there is a conf mismatch. Note that I am quite a new go-carbon user though

deniszh commented 1 year ago

I released v0.17.1 (and v0.17.0 but forgot to bump version there), but not sure about issue which you mentioned. We're using master in production and it's working fine.

cboudereau commented 1 year ago

This issue was about using the v0.16.2 with the latest example.

Thank you for the release

cboudereau commented 1 year ago

Did you pushed a tag for docker images ?

deniszh commented 1 year ago

Yes, I did - https://github.com/go-graphite/go-carbon/pkgs/container/go-carbon

cboudereau commented 1 year ago

Thanks