Supported version of protocol

go-graphite / graphite-clickhouse

Graphite cluster backend with ClickHouse support

MIT License

213 stars 52 forks source link

Supported version of protocol #28

Closed grzkv closed 3 years ago

grzkv commented 5 years ago

Looks like the protocol in https://github.com/lomik/graphite-clickhouse/blob/master/carbonzipperpb/carbonzipper.proto is derived from v1 of go-graphite/protocol.

How about supporting v2 or v3? Are there any fundamental limitations to this?

lomik commented 5 years ago

v1 and v2 protocols are equal (except of carbonserver specific methods). v3 supported only in latest versions of go-graphite/carbonapi. I use carbonapi-0.9.2 with some patches

grzkv commented 5 years ago

So, looks like we can use your lib if we support v2, right? But we will not be able to use MetricDetails.

lomik commented 5 years ago

I don't understand. What "lib" you want to use?

grzkv commented 5 years ago

I mean, graphite-clickhouse. It's not a lib, sorry for misnaming it.

lomik commented 5 years ago

yep, graphite-clickhouse works fine with carbonapi protocol v2

Felixoid commented 3 years ago

Since #85 the project supports pbv3, so it's solved